Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add g:clap_project_root_markers #290

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Add g:clap_project_root_markers #290

merged 5 commits into from
Feb 4, 2020

Conversation

liuchengxu
Copy link
Owner

Close #283

@liuchengxu liuchengxu mentioned this pull request Feb 2, 2020
Closed
github-actions[bot]
github-actions bot reviewed Feb 2, 2020
View reviewed changes
@liuchengxu liuchengxu merged commit 7e18eaa into master Feb 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the project-root-marker branch February 4, 2020 00:35
@markwu
Copy link
Contributor

markwu commented Feb 4, 2020

I saw the document, the default value is ['.root', '.git', '.git/']. I am a little bit confused, what's the different between .git and .git/.

If I want to add .svn into my root marker support, should I also add .svn/?

@liuchengxu
Copy link
Owner Author

liuchengxu commented Feb 4, 2020 •
edited
Loading

.git is for git submodule, ref #164 .

@markwu
Copy link
Contributor

markwu commented Feb 4, 2020

Ah, I see. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project root for mono-repos
2 participants
@liuchengxu @markwu