Don't match filepath in grep2

[liuchengxu]

Fix #383 (comment)

Also fix some errors found in maple.

[vn-ki]

Yes, this work!

I found more problems with grep2 though.

As you can see fuzzy is given more preference in grep2 than letter case. I find this behaviour very weird.

[vn-ki]

See how the result changes when one extra letter is added,

[liuchengxu]

Just like what I have mentioned in https://github.com/liuchengxu/vim-clap/blob/master/CHANGELOG.md#added, that's expected at the moment, for grep2 is forced to use the fzy fuzzy algorithm, but grep is not, which returns the result of ripgrep directly. We could borrow the extended search syntax of grep to grep2 later, prepend ' at the beginning of the query to not use the fuzzy filtering. But for now, that's how grep2 works.

[liuchengxu]

@vn-ki Can you show me the link of the repo used in your above picture?

[vn-ki]

https://github.com/vn-ki/harsark.rs

I find fuzzy really unsuitable for text searching.

[liuchengxu]

@vn-ki You just spot a bug of clap! This patch should help at present.

diff --git a/autoload/clap/filter/async/dyn.vim b/autoload/clap/filter/async/dyn.vim
index 66b043b..6e3e732 100644
--- a/autoload/clap/filter/async/dyn.vim
+++ b/autoload/clap/filter/async/dyn.vim
@@ -30,7 +30,7 @@ function! clap#filter#async#dyn#from_tempfile(tempfile) abort
   else
     let enable_icon_opt = ''
   endif
-  let filter_cmd = printf('%s --number 100 --winwidth %d filter "%s" --input "%s"',
+  let filter_cmd = printf('%s --number 30 --winwidth %d filter "%s" --input "%s"',
         \ enable_icon_opt,
         \ winwidth(g:clap.display.winid),
         \ g:clap.input.get(),
@@ -41,7 +41,7 @@ endfunction
 
 function! clap#filter#async#dyn#start_grep() abort
   let s:last_query = g:clap.input.get()
-  let grep_cmd = printf('%s --number 100 --winwidth %d grep "" "%s" --cmd-dir "%s"',
+  let grep_cmd = printf('%s --number 30 --winwidth %d grep "" "%s" --cmd-dir "%s"',
         \ g:clap_enable_icon ? '--enable-icon' : '',
         \ winwidth(g:clap.display.winid),
         \ g:clap.input.get(),
@@ -53,7 +53,7 @@ endfunction
 
 function! clap#filter#async#dyn#grep_from_cache(tempfile) abort
   let s:last_query = g:clap.input.get()
-  let grep_cmd = printf('%s %s --number 100 --winwidth %d grep "" "%s" --input "%s"',
+  let grep_cmd = printf('%s %s --number 30 --winwidth %d grep "" "%s" --input "%s"',
         \ g:clap_enable_icon ? '--enable-icon' : '',
         \ has_key(g:clap.context, 'no-cache') ? '--no-cache' : '',
         \ winwidth(g:clap.display.winid),

The problem is this number 30 is not configurable for this reason:

vim-clap/crates/maple_cli/src/cmd/filter/dynamic.rs

Line 11 in 386e94e

const ITEMS_TO_SHOW: usize = 30;

To make clap faster, I force to only take top 30 items in the results. People with a big screen might think 30 rows are not enough, but we should know that the performance can be worse when we want to show more top items. Maybe we could allow it to have a few limited options, e.g., [30, 40, 50].

[liuchengxu]

@vn-ki The issue you found should be fixed on mater now. The future improvements could be to add new filter approach aside from the current fuzzy filter ways, e.g, plain string match. https://github.com/junegunn/fzf#search-syntax is also nice to have, but it might need quite a work.

[liuchengxu]

@vn-ki Another dyn filter bug has been fixed, now the filtered results should be right e53d3c1 , I was wondering why some entries are not put on the top.