Switch line number and tag in finder rows #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make some sense, thanks! |
|
Unfortunately this broke FZF preview... preview.sh expects the arguments in reverse order:
But now it gets:
Which causes an error. I've tested this on multiple machines. |
dkarter
added a commit
to dkarter/vista.vim
that referenced
this pull request
Mar 7, 2020
This was broken since liuchengxu#231 when the object name and line number were reversed. This PR uses grep to grab the line number only and pass it to fzf preview.sh in the format it expects
liuchengxu
pushed a commit
that referenced
this pull request
Mar 12, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch positions of line number and tag in finder rows like below:
Before
After
In the normal vista window, tags place before line numbers like below. I think finder's columns order should be same as the window. Furthermore, tags which I think we might be most interested in will be aligned by this change like
Afterimage.Does this make sense?