From 8ddf0bd08deb822b7a7ebd2e718cc48829502b6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?The=CC=81o=20Monnom?= Date: Tue, 4 Mar 2025 22:53:13 +0100 Subject: [PATCH 1/4] wip --- livekit-rtc/livekit/rtc/apm.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/livekit-rtc/livekit/rtc/apm.py b/livekit-rtc/livekit/rtc/apm.py index 296ca55d..19ffe36c 100644 --- a/livekit-rtc/livekit/rtc/apm.py +++ b/livekit-rtc/livekit/rtc/apm.py @@ -15,25 +15,25 @@ class AudioProcessingModule: def __init__( self, *, - echo_canceller_enabled: bool = False, - noise_suppression_enabled: bool = False, - high_pass_filter_enabled: bool = False, - gain_controller_enabled: bool = False, + echo_cancellation: bool = False, + noise_suppression: bool = False, + high_pass_filter: bool = False, + auto_gain_control: bool = False, ) -> None: """ Initialize an AudioProcessingModule instance with the specified audio processing features. Args: - echo_canceller_enabled (bool, optional): Whether to enable echo cancellation. - noise_suppression_enabled (bool, optional): Whether to enable noise suppression. - high_pass_filter_enabled (bool, optional): Whether to enable a high-pass filter. - gain_controller_enabled (bool, optional): Whether to enable a gain controller. + echo_cancellation (bool, optional): Whether to enable echo cancellation. + noise_suppression (bool, optional): Whether to enable noise suppression. + high_pass_filter (bool, optional): Whether to enable a high-pass filter. + auto_gain_control (bool, optional): Whether to enable a gain controller. """ req = proto_ffi.FfiRequest() - req.new_apm.echo_canceller_enabled = echo_canceller_enabled - req.new_apm.noise_suppression_enabled = noise_suppression_enabled - req.new_apm.high_pass_filter_enabled = high_pass_filter_enabled - req.new_apm.gain_controller_enabled = gain_controller_enabled + req.new_apm.echo_canceller_enabled = echo_cancellation + req.new_apm.noise_suppression_enabled = noise_suppression + req.new_apm.high_pass_filter_enabled = high_pass_filter + req.new_apm.gain_controller_enabled = auto_gain_control resp = FfiClient.instance.request(req) self._ffi_handle = FfiHandle(resp.new_apm.apm.handle.id) From 1e8f8bb886d611bd7ff2c7938930cb264aae749b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?The=CC=81o=20Monnom?= Date: Tue, 4 Mar 2025 22:54:55 +0100 Subject: [PATCH 2/4] rtc-v0.21.1 --- livekit-rtc/livekit/rtc/version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/livekit-rtc/livekit/rtc/version.py b/livekit-rtc/livekit/rtc/version.py index 6a726d85..76f24586 100644 --- a/livekit-rtc/livekit/rtc/version.py +++ b/livekit-rtc/livekit/rtc/version.py @@ -1 +1 @@ -__version__ = "0.21.0" +__version__ = "0.21.1" From 945e04bdf5869de90d163f55ff45ab3691ce206b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?The=CC=81o=20Monnom?= Date: Tue, 4 Mar 2025 22:56:35 +0100 Subject: [PATCH 3/4] fix tests --- livekit-rtc/tests/test_apm.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/livekit-rtc/tests/test_apm.py b/livekit-rtc/tests/test_apm.py index d48cb958..da3d7ab1 100644 --- a/livekit-rtc/tests/test_apm.py +++ b/livekit-rtc/tests/test_apm.py @@ -17,10 +17,10 @@ def test_audio_processing(): # Initialize APM with echo cancellation enabled apm = AudioProcessingModule( - echo_canceller_enabled=True, - noise_suppression_enabled=True, - high_pass_filter_enabled=True, - gain_controller_enabled=True, + echo_cancellation=True, + noise_suppression=True, + high_pass_filter=True, + auto_gain_control=True, ) print("APM Internal Handle:", apm._ffi_handle) From 719506fc729e5a0ddd80a561395be7a981fc1cd5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9o=20Monnom?= Date: Tue, 4 Mar 2025 22:57:30 +0100 Subject: [PATCH 4/4] Update livekit-rtc/livekit/rtc/apm.py Co-authored-by: David Zhao --- livekit-rtc/livekit/rtc/apm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/livekit-rtc/livekit/rtc/apm.py b/livekit-rtc/livekit/rtc/apm.py index 19ffe36c..61fef9e6 100644 --- a/livekit-rtc/livekit/rtc/apm.py +++ b/livekit-rtc/livekit/rtc/apm.py @@ -27,7 +27,7 @@ def __init__( echo_cancellation (bool, optional): Whether to enable echo cancellation. noise_suppression (bool, optional): Whether to enable noise suppression. high_pass_filter (bool, optional): Whether to enable a high-pass filter. - auto_gain_control (bool, optional): Whether to enable a gain controller. + auto_gain_control (bool, optional): Whether to enable auto gain control. """ req = proto_ffi.FfiRequest() req.new_apm.echo_canceller_enabled = echo_cancellation