Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sometimes there is a double click sound when clicking just once on a character ImageButton. #1

Open
liweiyap opened this issue Mar 14, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@liweiyap
Copy link
Owner

liweiyap commented Mar 14, 2021

Phone model: Samsung Galaxy A3 (2016)
Phone API: 24 (Nougat)

Emulator model: Pixel XL
Emulator API: 30 (R)

Case 1:

  • 5-player mode
  • Uncheck Merlin, so the current characters are: Loyal0, Loyal1, Loyal2, Minion0, and Minion1.
  • Check Mordred, so the current characters are: Merlin, Percival, Loyal0, Assassin, and Mordred.
  • A double click sound is heard, because when checking Mordred, the function performClick() is called on Mordred (first click sound) and then on both Merlin and Percival (second and third click sounds overlap).
  • This is simply due to how the selection rules are written in CharacterSelectionActivity.

It seems that the double click sound is heard only on the phone, but hardly on the emulator. This could be because the phone model/API is old, or because of lag issues?

Whatever the case, in my opinion, the double click sound has no real adverse effect on character selection. Hence, I won't be fixing this. Someone else is welcome to fix this if he/she is interested to help improve the user experience.

@liweiyap liweiyap added the wontfix This will not be worked on label Mar 14, 2021
@liweiyap
Copy link
Owner Author

The double click sound is not (😁) observed on the following device:

Phone model: Samsung Galaxy A32 5G
Phone API: 30 (R)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant