Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Need of a linter in Sugarizer #1715

Open
AdityaKrSingh26 opened this issue Jan 23, 2025 · 2 comments
Open

Need of a linter in Sugarizer #1715

AdityaKrSingh26 opened this issue Jan 23, 2025 · 2 comments
Labels

Comments

@AdityaKrSingh26
Copy link

Different activities of Sugarizer have different indentations. Adding a linter will make sure that the indentations through out the codebase is uniform and remove any indentation issues while making any new changes.

@AdityaKrSingh26
Copy link
Author

@llaske please have a look at this. If it is a valid need i would like to work upon this.

@llaske
Copy link
Owner

llaske commented Jan 25, 2025

Adding a linter is a good idea but it will change lot of files in lot of activities.
And these changes will irremediably have an impact on file history so will have an impact on maintenance because the rule: "do not change a file/a line that don't need to be change" is essential to keep the repo maintainable.
I'm aware that having different indentation styles is not ideal and force contributors to be vigilant but I think it's the best solution.
So, no linter.

@llaske llaske added the wontfix label Jan 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants