Skip to content

Commit 2ee8763

Browse files
[test] Fix expected line number in TestRunner.py (#73996)
My #73541 added lines to `llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt` so what was previously on line 7 is now on line 12. Before: https://github.com/llvm/llvm-project/blob/28412d1800e391c5ba8e7607bb15c74b106d581b/llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt#L7-L8 After: https://github.com/llvm/llvm-project/blob/6fb7c2d713587a061cd281eda917746750559380/llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt#L12-L13 This didn't show up in the PR checks, but caused a buildbot failure after merging, https://lab.llvm.org/buildbot/#/builders/139/builds/54597 : ``` # | ====================================================================== # | FAIL: test_commands (__main__.TestIntegratedTestKeywordParser) # | ---------------------------------------------------------------------- # | Traceback (most recent call last): # | File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/utils/lit/tests/unit/TestRunner.py", line 135, in test_commands # | self.assertEqual(value[1].command.strip(), "%dbg(MY_RUN: at line 7) foo bar") # | AssertionError: '%dbg(MY_RUN: at line 12) foo bar' != '%dbg(MY_RUN: at line 7) foo bar' # | - %dbg(MY_RUN: at line 12) foo bar # | ? ^^ # | + %dbg(MY_RUN: at line 7) foo bar # | ? ^ ``` Apologies for the build break 🙀
1 parent dd1e72c commit 2ee8763

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/utils/lit/tests/unit/TestRunner.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def test_commands(self):
132132
value = cmd_parser.getValue()
133133
self.assertEqual(len(value), 2) # there are only two run lines
134134
self.assertEqual(value[0].command.strip(), "%dbg(MY_RUN: at line 4) baz")
135-
self.assertEqual(value[1].command.strip(), "%dbg(MY_RUN: at line 7) foo bar")
135+
self.assertEqual(value[1].command.strip(), "%dbg(MY_RUN: at line 12) foo bar")
136136

137137
def test_boolean(self):
138138
parsers = self.make_parsers()

0 commit comments

Comments
 (0)