Skip to content

Commit bc97751

Browse files
committed
[NFC] Add GitHub issues to HLSL FIXME comments
In order to make this easier to track I've filed issues for each of the HLSL FIXME comments that I can find. I may have missed some, but I want this to be the new default mode.
1 parent 10207fc commit bc97751

File tree

4 files changed

+5
-0
lines changed

4 files changed

+5
-0
lines changed

clang/lib/CodeGen/CGHLSLRuntime.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,15 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl *FD,
143143
IRBuilder<> B(BB);
144144
llvm::SmallVector<Value *> Args;
145145
// FIXME: support struct parameters where semantics are on members.
146+
// See: https://github.com/llvm/llvm-project/issues/57874
146147
for (const auto *Param : FD->parameters()) {
147148
Args.push_back(emitInputSemantic(B, *Param));
148149
}
149150

150151
CallInst *CI = B.CreateCall(FunctionCallee(Fn), Args);
151152
(void)CI;
152153
// FIXME: Handle codegen for return type semantics.
154+
// See: https://github.com/llvm/llvm-project/issues/57875
153155
B.CreateRetVoid();
154156
}
155157

clang/lib/Driver/ToolChains/HLSL.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,5 +209,6 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,
209209
}
210210
// FIXME: add validation for enable_16bit_types should be after HLSL 2018 and
211211
// shader model 6.2.
212+
// See: https://github.com/llvm/llvm-project/issues/57876
212213
return DAL;
213214
}

clang/lib/Sema/SemaDecl.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11896,6 +11896,7 @@ void Sema::CheckHLSLEntryPoint(FunctionDecl *FD) {
1189611896
for (const auto *Param : FD->parameters()) {
1189711897
if (!Param->hasAttr<HLSLAnnotationAttr>()) {
1189811898
// FIXME: Handle struct parameters where annotations are on struct fields.
11899+
// See: https://github.com/llvm/llvm-project/issues/57875
1189911900
Diag(FD->getLocation(), diag::err_hlsl_missing_semantic_annotation);
1190011901
Diag(Param->getLocation(), diag::note_previous_decl) << Param;
1190111902
FD->setInvalidDecl();

clang/test/CodeGenHLSL/validator_version.hlsl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %clang -cc1 -S -triple dxil-pc-shadermodel6.3-library -S -emit-llvm -xhlsl -validator-version 1.1 -o - %s | FileCheck %s
22

33
// FIXME:The following line should work once SPIR-V support for HLSL is added.
4+
// See: https://github.com/llvm/llvm-project/issues/57877
45
// DISABLED: %clang -cc1 -S -triple spirv32 -S -emit-llvm -xhlsl -validator-version 1.1 -o - %s | FileCheck %s --check-prefix=NOT_DXIL
56

67
// CHECK:!dx.valver = !{![[valver:[0-9]+]]}

0 commit comments

Comments
 (0)