[FuncitonComparator] Clamp StringRef compare output to [-1,1]

d0k · d0k · commit db6961db7a0d · 2023-01-16T01:44:55.000+01:00
The comparison can have different values (but same sign) on big endian
platforms, avoid that to make the unit test green there.
diff --git a/llvm/lib/Transforms/Utils/FunctionComparator.cpp b/llvm/lib/Transforms/Utils/FunctionComparator.cpp
@@ -110,7 +110,7 @@ int FunctionComparator::cmpMem(StringRef L, StringRef R) const {
 
   // Compare strings lexicographically only when it is necessary: only when
   // strings are equal in size.
-  return L.compare(R);
+  return std::clamp(L.compare(R), -1, 1);
 }
 
 int FunctionComparator::cmpAttrs(const AttributeList L,

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ int FunctionComparator::cmpMem(StringRef L, StringRef R) const {`
`110`	`110`
`111`	`111`	`// Compare strings lexicographically only when it is necessary: only when`
`112`	`112`	`// strings are equal in size.`
`113`		`- return L.compare(R);`
	`113`	`+ return std::clamp(L.compare(R), -1, 1);`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`int FunctionComparator::cmpAttrs(const AttributeList L,`