[clang-tidy] Clang tidy failed 6.3.0

[RandUser123sa]

I'm receive the following error when trying to compile migraphx:

 67%] Building CXX object src/onnx/CMakeFiles/migraphx_onnx.dir/parse_instancenorm.cpp.o
clang-tidy: /mnt/arch/rocm/release/llvm-project-rocm-6.3.0/clang/lib/AST/ExprConstant.cpp:15679: bool clang::Expr::EvaluateAsInt(EvalResult&, const clang::ASTContext&, SideEffectsKind, bool) const: Assertion `!isValueDependent() && "Expression evaluator can't be called on a dependent expression."' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: /opt/rocm/llvm/bin/clang-tidy --use-color --config-file=/mnt/arch/rocm/release/AMDMIGraphX-rocm-6.3.0/.clang-tidy -quiet -p /mnt/arch/rocm/rocm-build/build/amdmigraphx -checks=boost-*,bugprone-*,cert-*,clang-analyzer-*,clang-diagnostic-*,cppcoreguidelines-*,google-*,hicpp-multiway-paths-covered,hicpp-signed-bitwise,llvm-namespace-comment,misc-*,-misc-confusable-identifiers,-misc-use-anonymous-namespace,modernize-*,performance-*,readability-*,-bugprone-easily-swappable-parameters,-bugprone-implicit-widening-of-multiplication-result,-bugprone-macro-parentheses,-bugprone-multi-level-implicit-pointer-conversion,-bugprone-signed-char-misuse,-bugprone-unchecked-optional-access,-bugprone-unused-local-non-trivial-variable,-cert-dcl37-c,-cert-dcl51-cpp,-cert-err33-c,-cert-str34-c,-cert-msc32-c,-cert-msc51-cpp,-clang-analyzer-alpha*,clang-analyzer-alpha.core.CallAndMessageUnInitRefArg,clang-analyzer-alpha.core.Conversion,clang-analyzer-alpha.core.IdenticalExpr,clang-analyzer-alpha.core.PointerArithm,clang-analyzer-alpha.core.PointerSub,clang-analyzer-alpha.core.TestAfterDivZero,clang-analyzer-alpha.cplusplus.InvalidIterator,clang-analyzer-alpha.cplusplus.IteratorRange,clang-analyzer-alpha.cplusplus.MismatchedIterator,clang-analyzer-alpha.cplusplus.MisusedMovedObject,-bugprone-switch-missing-default-case,-bugprone-empty-catch,-clang-analyzer-optin.performance.Padding,-clang-diagnostic-deprecated-declarations,-clang-diagnostic-disabled-macro-expansion,-clang-diagnostic-extern-c-compat,-clang-diagnostic-unused-command-line-argument,-cppcoreguidelines-avoid-capture-default-when-capturing-this,-cppcoreguidelines-avoid-const-or-ref-data-members,-cppcoreguidelines-avoid-do-while,-cppcoreguidelines-explicit-virtual-functions,-cppcoreguidelines-init-variables,-cppcoreguidelines-misleading-capture-default-by-value,-cppcoreguidelines-missing-std-forward,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-rvalue-reference-param-not-moved,-cppcoreguidelines-special-member-functions,-cppcoreguidelines-use-default-member-init,-cppcoreguidelines-virtual-class-destructor,-google-readability-*,-google-runtime-int,-google-runtime-references,-misc-include-cleaner,-misc-macro-parentheses,-misc-no-recursion,-modernize-concat-nested-namespaces,-modernize-pass-by-value,-modernize-type-traits,-modernize-use-default-member-init,-modernize-use-nodiscard,-modernize-use-override,-modernize-use-trailing-return-type,-modernize-use-transparent-functors,-performance-avoid-endl,-performance-type-promotion-in-math-fn,-performance-enum-size,-readability-braces-around-statements,-readability-avoid-nested-conditional-operator,-readability-convert-member-functions-to-static,-readability-else-after-return,-readability-function-cognitive-complexity,-readability-identifier-length,-readability-named-parameter,-readability-redundant-member-init,-readability-redundant-string-init,-readability-suspicious-call-argument,-readability-uppercase-literal-suffix,-*-avoid-c-arrays,-*-explicit-constructor,-*-magic-numbers,-*-narrowing-conversions,-*-non-private-member-variables-in-classes,-*-use-auto,-*-use-emplace,-*-use-equals-default -warnings-as-errors= -extra-arg=-UNDEBUG -extra-arg=-DMIGRAPHX_USE_CLANG_TIDY -extra-arg=-Xclang -extra-arg=-analyzer-max-loop -extra-arg=-Xclang -extra-arg=10 -extra-arg=-Xclang -extra-arg=-analyzer-inline-max-stack-depth -extra-arg=-Xclang -extra-arg=10 -extra-arg=-Xclang -extra-arg=-analyzer-config -extra-arg=-Xclang -extra-arg=optin.cplusplus.UninitializedObject:Pedantic=true -extra-arg=-Xclang -extra-arg=-analyzer-config -extra-arg=-Xclang -extra-arg=widen-loops=true -extra-arg=-Xclang -extra-arg=-analyzer-config -extra-arg=-Xclang -extra-arg=unroll-loops=true -extra-arg=-Xclang -extra-arg=-analyzer-config -extra-arg=-Xclang -extra-arg=cfg-lifetime=true -extra-arg=-Xclang -extra-arg=-analyzer-config -extra-arg=-Xclang -extra-arg=cfg-scopes=true -header-filter=.*hpp /mnt/arch/rocm/release/AMDMIGraphX-rocm-6.3.0/src/tf/op_parser.cpp -export-fixes=/mnt/arch/rocm/rocm-build/build/amdmigraphx/fixits/migraphx_tf-_mnt_arch_rocm_release_AMDMIGraphX_rocm_6_3_0_src_tf_op_parser_cpp.yaml
1.      <eof> parser at end of file
2.      ASTMatcher: Processing 'bugprone-not-null-terminated-result' against:
        CallExpr : </usr/include/google/protobuf/message_lite.h:1245:7, col:50>
--- Bound Nodes Begin ---
    DestExpr - { DeclRefExpr : </usr/include/google/protobuf/message_lite.h:1245:14> }
    DestVarDecl - { VarDecl dst : </usr/include/google/protobuf/message_lite.h:1207:3, col:37> }
    FunctionExpr - { CallExpr : </usr/include/google/protobuf/message_lite.h:1245:7, col:50> }
    LengthExpr - { IntegerLiteral : </usr/include/google/protobuf/message_lite.h:1245:48> }
    SrcExpr - { DeclRefExpr : </usr/include/google/protobuf/message_lite.h:1245:31> }
    SrcVarDecl - { VarDecl src : </usr/include/google/protobuf/message_lite.h:1209:3, col:69> }
    UnknownDest - { DeclRefExpr : </usr/include/google/protobuf/message_lite.h:1245:14> }
    WrongLength - { IntegerLiteral : </usr/include/google/protobuf/message_lite.h:1245:48> }
--- Bound Nodes End ---
 #0 0x00000000044cc32b llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/opt/rocm/llvm/bin/clang-tidy+0x44cc32b)
 #1 0x00000000044c93bb (/opt/rocm/llvm/bin/clang-tidy+0x44c93bb)
 #2 0x00007f0cd62430d0 __restore_rt (/lib64/libc.so.6+0x430d0)
 #3 0x00007f0cd629b3bb pthread_kill@@GLIBC_2.34 (/lib64/libc.so.6+0x9b3bb)
 #4 0x00007f0cd6243032 gsignal (/lib64/libc.so.6+0x43032)
 #5 0x00007f0cd62284a2 abort (/lib64/libc.so.6+0x284a2)
 #6 0x00007f0cd62283d8 _nl_load_domain.cold (/lib64/libc.so.6+0x283d8)
 #7 0x00007f0cd623a4f2 (/lib64/libc.so.6+0x3a4f2)
 #8 0x0000000003332ba2 (/opt/rocm/llvm/bin/clang-tidy+0x3332ba2)
 #9 0x0000000000b74ad4 (/opt/rocm/llvm/bin/clang-tidy+0xb74ad4)
#10 0x0000000000b762a8 (/opt/rocm/llvm/bin/clang-tidy+0xb762a8)
#11 0x0000000000b7ca38 clang::tidy::bugprone::NotNullTerminatedResultCheck::memoryHandlerFunctionFix(llvm::StringRef, clang::ast_matchers::MatchFinder::MatchResult const&) (/opt/rocm/llvm/bin/clang-tidy+0xb7ca38)
#12 0x0000000002fbb4fb (/opt/rocm/llvm/bin/clang-tidy+0x2fbb4fb)
#13 0x0000000002fee08a clang::ast_matchers::internal::BoundNodesTreeBuilder::visitMatches(clang::ast_matchers::internal::BoundNodesTreeBuilder::Visitor*) (/opt/rocm/llvm/bin/clang-tidy+0x2fee08a)
#14 0x0000000002fbe2ca (/opt/rocm/llvm/bin/clang-tidy+0x2fbe2ca)
#15 0x0000000002fda8b3 (/opt/rocm/llvm/bin/clang-tidy+0x2fda8b3)
#16 0x0000000002fdab56 (/opt/rocm/llvm/bin/clang-tidy+0x2fdab56)
#17 0x0000000002fda74b (/opt/rocm/llvm/bin/clang-tidy+0x2fda74b)
#18 0x0000000002fdac1b (/opt/rocm/llvm/bin/clang-tidy+0x2fdac1b)
#19 0x0000000002fe1e59 (/opt/rocm/llvm/bin/clang-tidy+0x2fe1e59)
#20 0x0000000002fe7083 (/opt/rocm/llvm/bin/clang-tidy+0x2fe7083)
#21 0x0000000002fd6cf8 (/opt/rocm/llvm/bin/clang-tidy+0x2fd6cf8)
#22 0x0000000002fe787c (/opt/rocm/llvm/bin/clang-tidy+0x2fe787c)
#23 0x0000000002fd6cf8 (/opt/rocm/llvm/bin/clang-tidy+0x2fd6cf8)
#24 0x0000000002fd6dda (/opt/rocm/llvm/bin/clang-tidy+0x2fd6dda)
#25 0x0000000002fd640a (/opt/rocm/llvm/bin/clang-tidy+0x2fd640a)
#26 0x0000000002fd6cf8 (/opt/rocm/llvm/bin/clang-tidy+0x2fd6cf8)
#27 0x0000000002fd6dda (/opt/rocm/llvm/bin/clang-tidy+0x2fd6dda)
#28 0x0000000002fd640a (/opt/rocm/llvm/bin/clang-tidy+0x2fd640a)
#29 0x0000000002fd6cf8 (/opt/rocm/llvm/bin/clang-tidy+0x2fd6cf8)
#30 0x0000000002fd6dda (/opt/rocm/llvm/bin/clang-tidy+0x2fd6dda)
#31 0x0000000002fd640a (/opt/rocm/llvm/bin/clang-tidy+0x2fd640a)
#32 0x0000000002fd6cf8 (/opt/rocm/llvm/bin/clang-tidy+0x2fd6cf8)
#33 0x0000000002fd6dda (/opt/rocm/llvm/bin/clang-tidy+0x2fd6dda)
#34 0x0000000002fe6ed7 (/opt/rocm/llvm/bin/clang-tidy+0x2fe6ed7)
#35 0x0000000002fd6cf8 (/opt/rocm/llvm/bin/clang-tidy+0x2fd6cf8)
#36 0x0000000002fd7040 clang::ast_matchers::MatchFinder::matchAST(clang::ASTContext&) (/opt/rocm/llvm/bin/clang-tidy+0x2fd7040)
#37 0x0000000001d85480 clang::MultiplexConsumer::HandleTranslationUnit(clang::ASTContext&) (/opt/rocm/llvm/bin/clang-tidy+0x1d85480)
#38 0x0000000002041ce9 clang::ParseAST(clang::Sema&, bool, bool) (/opt/rocm/llvm/bin/clang-tidy+0x2041ce9)
#39 0x0000000001d48c39 clang::FrontendAction::Execute() (/opt/rocm/llvm/bin/clang-tidy+0x1d48c39)
#40 0x0000000001cbd1b6 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/opt/rocm/llvm/bin/clang-tidy+0x1cbd1b6)
#41 0x000000000153b53d clang::tooling::FrontendActionFactory::runInvocation(std::shared_ptr<clang::CompilerInvocation>, clang::FileManager*, std::shared_ptr<clang::PCHContainerOperations>, clang::DiagnosticConsumer*) (/opt/rocm/llvm/bin/clang-tidy+0x153b53d)
#42 0x00000000014d42c4 (/opt/rocm/llvm/bin/clang-tidy+0x14d42c4)
#43 0x0000000001532a7c clang::tooling::ToolInvocation::runInvocation(char const*, clang::driver::Compilation*, std::shared_ptr<clang::CompilerInvocation>, std::shared_ptr<clang::PCHContainerOperations>) (/opt/rocm/llvm/bin/clang-tidy+0x1532a7c)
#44 0x000000000153679d clang::tooling::ToolInvocation::run() (/opt/rocm/llvm/bin/clang-tidy+0x153679d)
#45 0x00000000015389d4 clang::tooling::ClangTool::run(clang::tooling::ToolAction*) (/opt/rocm/llvm/bin/clang-tidy+0x15389d4)
#46 0x00000000014e0300 clang::tidy::runClangTidy(clang::tidy::ClangTidyContext&, clang::tooling::CompilationDatabase const&, llvm::ArrayRef<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>, llvm::IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem>, bool, bool, llvm::StringRef) (/opt/rocm/llvm/bin/clang-tidy+0x14e0300)
#47 0x00000000009fe3ee clang::tidy::clangTidyMain(int, char const**) (/opt/rocm/llvm/bin/clang-tidy+0x9fe3ee)
#48 0x00007f0cd6229d57 __libc_start_call_main (/lib64/libc.so.6+0x29d57)
#49 0x00007f0cd6229e15 __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x29e15)
#50 0x00000000009f2a81 _start (/opt/rocm/llvm/bin/clang-tidy+0x9f2a81)

CMake Error at tidy-target-migraphx_tf-_mnt_arch_rocm_release_AMDMIGraphX_rocm_6_3_0_src_tf_op_parser_cpp.cmake:82 (message):
  Clang tidy failed.


make[2]: *** [src/tf/CMakeFiles/tidy-target-migraphx_tf-_mnt_arch_rocm_release_AMDMIGraphX_rocm_6_3_0_src_tf_op_parser_cpp.dir/build.make:71: src/tf/CMakeFiles/tidy-target-migraphx_tf-_mnt_arch_rocm_release_AMDMIGraphX_rocm_6_3_0_src_tf_op_parser_cpp] Error 1
make[1]: *** [CMakeFiles/Makefile2:14705: src/tf/CMakeFiles/tidy-target-migraphx_tf-_mnt_arch_rocm_release_AMDMIGraphX_rocm_6_3_0_src_tf_op_parser_cpp.dir/all] Error 2

[EugeneZelenko]

Which version of Clang-tidy do you use?

[asl]

Which version of Clang-tidy do you use?

Seems to be from some vendor (AMD) downstream fork

[RandUser123sa]

OMP-18.0-12 (http://github.com/ROCm-Developer-Tools/aomp):
Source ID:18.0-12-ce1873ac686bb90ddec72bb99889a4e80e2de382
LLVM version 18.0.0git
Optimized build with assertions.

I added the same error but now with debug information clangerror.txt

[asl]

OMP-18.0-12 (http://github.com/ROCm-Developer-Tools/aomp):

Please report the problem to this downstream repo then. Or consider providing a reproducer for vanilla mainline clang

[RandUser123sa]

This issue is closed. The problem was -g1 optimization.