-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[SimplifyCFG] Need to remove useless comparison after turning switch to icmp #53853
Labels
Comments
LebedevRI
pushed a commit
that referenced
this issue
Feb 15, 2022
Based on original tests from D119839. See #53853
LebedevRI
pushed a commit
to LebedevRI/llvm-project
that referenced
this issue
Feb 23, 2022
Based on original tests from D119839. See llvm#53853
LebedevRI
added a commit
to LebedevRI/llvm-project
that referenced
this issue
Feb 23, 2022
…nge comparison and branch until after at least the IPSCCP That transformation is lossy, as discussed in llvm#53853 and rust-lang/rust#85133 (comment) This is an alternative to D119839, which would add a limited IPSCCP into SimplifyCFG. Unlike lowering switch to lookup, we still want this transformation to happen relatively early, but after giving a chance for the things like CVP to do their thing. It seems like deferring it just until the IPSCCP is enough for the tests at hand, but perhaps we need to be more aggressive and disable it until CVP. Fixes llvm#53853 Refs. rust-lang/rust#85133 Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D119854
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this issue
Feb 24, 2022
Based on original tests from D119839. See llvm#53853 (cherry picked from commit c9c9307)
nikic
pushed a commit
to nikic/llvm-project
that referenced
this issue
Mar 2, 2022
Based on original tests from D119839. See llvm#53853 (cherry picked from commit c9c9307)
nikic
pushed a commit
to nikic/llvm-project
that referenced
this issue
Mar 2, 2022
…nge comparison and branch until after at least the IPSCCP That transformation is lossy, as discussed in llvm#53853 and rust-lang/rust#85133 (comment) This is an alternative to D119839, which would add a limited IPSCCP into SimplifyCFG. Unlike lowering switch to lookup, we still want this transformation to happen relatively early, but after giving a chance for the things like CVP to do their thing. It seems like deferring it just until the IPSCCP is enough for the tests at hand, but perhaps we need to be more aggressive and disable it until CVP. Fixes llvm#53853 Refs. rust-lang/rust#85133 Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D119854 (cherry picked from commit 371fcb7)
tstellar
pushed a commit
to llvmbot/llvm-project
that referenced
this issue
Mar 9, 2022
Based on original tests from D119839. See llvm#53853
tstellar
pushed a commit
to llvmbot/llvm-project
that referenced
this issue
Mar 9, 2022
…nge comparison and branch until after at least the IPSCCP That transformation is lossy, as discussed in llvm#53853 and rust-lang/rust#85133 (comment) This is an alternative to D119839, which would add a limited IPSCCP into SimplifyCFG. Unlike lowering switch to lookup, we still want this transformation to happen relatively early, but after giving a chance for the things like CVP to do their thing. It seems like deferring it just until the IPSCCP is enough for the tests at hand, but perhaps we need to be more aggressive and disable it until CVP. Fixes llvm#53853 Refs. rust-lang/rust#85133 Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D119854
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this issue
Oct 7, 2022
Based on original tests from D119839. See llvm/llvm-project#53853
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this issue
Oct 7, 2022
…nge comparison and branch until after at least the IPSCCP That transformation is lossy, as discussed in llvm/llvm-project#53853 and rust-lang/rust#85133 (comment) This is an alternative to D119839, which would add a limited IPSCCP into SimplifyCFG. Unlike lowering switch to lookup, we still want this transformation to happen relatively early, but after giving a chance for the things like CVP to do their thing. It seems like deferring it just until the IPSCCP is enough for the tests at hand, but perhaps we need to be more aggressive and disable it until CVP. Fixes llvm/llvm-project#53853 Refs. rust-lang/rust#85133 Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D119854
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
For example,
See: https://godbolt.org/z/3nobrzoKa
This is a known issue from rust: rust-lang/rust#85133 (comment)
We want to get the IR result after SimplifyCFG:
The text was updated successfully, but these errors were encountered: