Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Background Removal - Update available! #495

Closed
Zahrun opened this issue Dec 13, 2023 · 8 comments
Closed

Background Removal - Update available! #495

Zahrun opened this issue Dec 13, 2023 · 8 comments
Labels
bug Something isn't working
Milestone

Comments

@Zahrun
Copy link

Zahrun commented Dec 13, 2023

Describe the bug

I get the window "Background Removal - Update available!" even though I am using version 1.1.7, which I believe is the latest.

To Reproduce

Steps to reproduce the behavior:

  1. Install obs-backgroundremoval 1.1.7
  2. Open OBS
  3. See the update available dialog

Expected behavior

Dialog does not show if I am on latest release.

Screenshots

image

Log

2023-12-13 10-53-30.txt

Desktop (please complete the following information):

  • OS: Tuxedo OS 2
  • Browser: Firefox
  • Plugin Version: 1.1.7
  • OBS Version: 30.0.0
@Zahrun Zahrun added the bug Something isn't working label Dec 13, 2023
@Zahrun
Copy link
Author

Zahrun commented Dec 13, 2023

PS: probably need to replace all references to obs-ai with occ-ai https://github.com/occ-ai/obs-backgroundremoval/blob/9a1d13c6784d499f88b1af22e9f3252daf0f3b45/src/update-checker/github-utils.cpp#L11

@royshil
Copy link
Collaborator

royshil commented Dec 13, 2023

@Zahrun yes you're absolutely right!

@royshil royshil added this to the 1.1.8 milestone Dec 13, 2023
@royshil
Copy link
Collaborator

royshil commented Dec 13, 2023

shuold be fixed by #496

@royshil
Copy link
Collaborator

royshil commented Dec 13, 2023

@Zahrun are you able to test the latest version with the fix?

@Zahrun
Copy link
Author

Zahrun commented Dec 14, 2023

I see that there is a "Build for Ubuntu" Github action. Where is the artifact?

@royshil
Copy link
Collaborator

royshil commented Dec 14, 2023

https://github.com/occ-ai/obs-backgroundremoval/actions/runs/7198176814#artifacts

every master push and every pull request have a build with artifacts

@Zahrun
Copy link
Author

Zahrun commented Dec 15, 2023

@Zahrun are you able to test the latest version with the fix?

Tested and approved.

@royshil
Copy link
Collaborator

royshil commented Dec 15, 2023

closing, done

@royshil royshil closed this as completed Dec 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants