Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Investigate MSW update issue #3043

Closed
fhennig opened this issue Oct 23, 2024 · 2 comments · Fixed by #3083
Closed

Investigate MSW update issue #3043

fhennig opened this issue Oct 23, 2024 · 2 comments · Fixed by #3083
Assignees
@fhennig
Labels
bug Something isn't working dependencies Pull requests that update a dependency file tests Test related issues website Tasks related to the web application

Comments

@fhennig
Copy link
Contributor

fhennig commented Oct 23, 2024 •
edited
Loading

Previously @corneliusroemer reported an issue that we run into when bumping msw: mswjs/msw#2273

The issue was unrelated to msw, but we still have a problem when bumping it. Needs more investigation.

This only affects the tests, so no real prod issues.

The issue appears in msw 2.4.6
@fhennig fhennig added bug Something isn't working website Tasks related to the web application dependencies Pull requests that update a dependency file tests Test related issues labels Oct 23, 2024
@fengelniederhammer
Copy link
Contributor

The title should be MSW, shouldn't it?

@fhennig fhennig changed the title Investigate MDW update issue Investigate MSW update issue Oct 23, 2024
@fhennig
Copy link
Contributor Author

fhennig commented Oct 23, 2024

yes, thanks!

@fhennig fhennig self-assigned this Oct 23, 2024
@fhennig fhennig mentioned this issue Oct 28, 2024
Merged
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@fhennig fhennig

Labels
bug Something isn't working dependencies Pull requests that update a dependency file tests Test related issues website Tasks related to the web application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump msw; switch to happy-dom for testing loculus-project/loculus
2 participants
@fhennig @fengelniederhammer