Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New file format #117

Open
Andres-MG opened this issue Dec 20, 2022 · 1 comment
Open

New file format #117

Andres-MG opened this issue Dec 20, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Andres-MG
Copy link
Collaborator

The current format is not very flexible and adding new output variables is somewhat challenging. I propose using something similar to this (unstructured grids), where the handling of the IO is performed by a third-party library (HDF5 in this case). This is already implemented as an export format #99; hopefully, we can reuse part of the work.

My idea is to separate the file into general information, nodal values, and element values. Backwards compatibility can be guaranteed if we keep the current file reader and switch readers depending on the file (file ending or magic numbers maybe?).

I will keep a list here of the data that needs to go into the file:

  • Equation
  • Type of nodes
  • Iteration
  • Time
  • Polynomial order per element
  • Nodal values
    • $Q$
    • $\nabla Q$ (optional)
    • Nodal sensor (optional)
  • Element values
    • MPI rank
    • Element sensor (optional)
    • Artificial viscosity (optional)
@Andres-MG Andres-MG added the enhancement New feature or request label Dec 20, 2022
@Andres-MG Andres-MG self-assigned this Dec 20, 2022
@loganoz
Copy link
Owner

loganoz commented Dec 21, 2022

File ending seems fine. Then it's easier to know what reader the code is actually using. We need to think on a new extension name to substitute old ".hsol".

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants