Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

watched files seems to not get released #270

Closed
kares opened this issue Apr 23, 2020 · 0 comments · Fixed by #271
Closed

watched files seems to not get released #270

kares opened this issue Apr 23, 2020 · 0 comments · Fixed by #271

Comments

@kares
Copy link
Contributor

kares commented Apr 23, 2020

from input's internal FileWatch::WatchedFilesCollection, the collection removes entries on errors
but seemingly (in read mode) when a file is processed and deleted the WatchedFile bits stays around.

collection will tend to grow, until LS is restarted, proportionally to the number of entries (over-time) in a directory. e.g. ~ 70k files coming and going in a directory will retain ~ 150MB of heap for the collection.

we need to look into releasing (deleted) file entries from the watcher to reduce memory use ... in some cases this might be clearly considered a potential leak.

Screenshot from 2020-04-23 21-59-03

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant