Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Why still on serialize-error@8? #128

Open
aqeelat opened this issue Oct 29, 2024 · 2 comments · May be fixed by #131
Open

Why still on serialize-error@8? #128

aqeelat opened this issue Oct 29, 2024 · 2 comments · May be fixed by #131

Comments

@aqeelat
Copy link

aqeelat commented Oct 29, 2024

Just wondering why the version is pinned to 8.1.0 in core?
@CHC383 CHC383 linked a pull request Jan 24, 2025 that will close this issue
Open
@CHC383
Copy link

CHC383 commented Jan 24, 2025

@aqeelat I think it is because serialize-error becomes pure ESM package since v9.0.0, but this repository still generates CJS packages. There might be a workaround to use ESM package in the CJS package by doing dynamic import.

@curusarn
Copy link
Contributor

Hey @aqeelat and @CHC383!

Sorry for the long silence here.
I'm passing this on to the team to get the PR reviewed and merged soon.

Thank you for raising and for the PR!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove dependency serialize-error CHC383/logtail-js
3 participants
@aqeelat @curusarn @CHC383