fix: Removes trailing and leading special chars from value dimension label #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om value dimension label
yjmg
reviewed
Jun 22, 2023
src/viz_gauge.js
Outdated
| @@ -136,7 +136,7 @@ function processPivot(data, queryResponse, config, viz, pivotKey) { | |||
| value_dimension: | |||
| config.value_label_override === undefined || | |||
| config.value_label_override === '' | |||
| ? pivotKey | |||
| ? pivotKey.replace(/(^| +)[!-\/:-@\[-`\{-~]*([^ ]*?)[!-\/:-@\[-`\{-~]*(?=\s|$)/gi, '$1$2') | |||
There was a problem hiding this comment.
- Please extract this into a separate function.
- Also create a constant for the regular expression.
- We need to check whether it's only the '$' sign or other special symbols as well.
- We'll also need to include before and after screenshots on the associated issue.
jeremytchang
pushed a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2024-01-03) ### Features * add jest for unit testing ([#11](#11)) ([76a5e49](76a5e49)) * some unit tests for some more utility functions. ([#12](#12)) ([1ccc019](1ccc019)) ### Bug Fixes * Removes trailing and leading special chars from value dimension label ([#10](#10)) ([4b50f5a](4b50f5a)) * Viz not updating after filter added or changed ([2c0e133](2c0e133)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.