feat: some unit tests for some more utility functions. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesudeep
force-pushed
the
feat-some-tests-for-utility-functions
branch
from
5b7438a to
924a30a
Compare
yesudeep
force-pushed
the
feat-some-tests-for-utility-functions
branch
from
924a30a to
110d199
Compare
jeremytchang
pushed a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2024-01-03) ### Features * add jest for unit testing ([#11](#11)) ([76a5e49](76a5e49)) * some unit tests for some more utility functions. ([#12](#12)) ([1ccc019](1ccc019)) ### Bug Fixes * Removes trailing and leading special chars from value dimension label ([#10](#10)) ([4b50f5a](4b50f5a)) * Viz not updating after filter added or changed ([2c0e133](2c0e133)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves 2 more functions into separate modules so that we can add unit tests
for them.
getLabelis now instring.jsand unit tests for it are found instring.test.jsmapBetweenis now inmath.jsand unit tests for it are found inmath.test.jsmapBetweenhas not been changed and the functionprobably needs to be updated to include validation.