Considering the switch to PHPUnit

[drupol]

For some reasons lately, I'm starting to consider to switching from PHPSpec to PHPUnit.

What do you think of the idea?

Motivation of the changes:

• I think the choice of a testing platform is crucial and responsiveness against an issue or a bug should be dealt in priority

[AlexandruGG]

@drupol I think I agree with this.

While I've enjoyed working with PHPSpec in this project (first time I worked with it!), I think there are some downsides to it which include a more restricted feature set compared to PHPUnit, and the maintainer not being as responsive as we'd like (I experienced this as well with the PHP 8 bug fix previously).

Also, it's quite clear the trend is towards PHPUnit, as also mentioned in the article I'll link below. There's a lot more development happening in PHPUnit I think.

My personal preference is PHPUnit + Prophecy (and prophecy-phpunit), this is what we use in projects at work. I still like the style and expressiveness of Prophecy.

We could use Rector to try make the migration:
https://tomasvotruba.com/blog/2019/03/21/how-to-instantly-migrate-phpspec-to-phpunit/

[TomasVotruba]

Thanks 👍
Is there some PR I could just check out so we avoid copy-paste bugs?

[drupol]

Let me do it.

[drupol]

Here you go: #176

[TomasVotruba]

Thanks... I worked on it for last 2 hours and it seems there was a bug when moving file that was modified.

Could you try latest Rector in composer.json?

{
    "requires": {
        "rector/rector": "dev-main#b2c929a",
    },
    "minimum-stability": "dev",
    "prefer-stable": true
}

I tried locally on your PR and looks good :)

[drupol]

Indeed, classes are different now. I will gave it a in-depth look tonight, I have some work to finish first 🙇‍♂️