Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add open-with-cmd and bookmarks plugins #14

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add open-with-cmd and bookmarks plugins #14

wants to merge 8 commits into from

Conversation

Mcrtin
Copy link

@Mcrtin Mcrtin commented Jan 21, 2025 •
edited
Loading

  • feat: Add plugin: Bookmarks
  • feat: Add plugin: open-with-cmd

I think I'm using a different formatter then you guys ._.
I named the key binds using under_scores; I didn't know which convention to use.

In Bookmarks, the marks are not persistent by default; one has to change the init parameters, i.e.

require("bookmarks"):setup({
	last_directory = { enable = true, persist = false },
	persist = "vim",
	desc_format = "parent",
	notify = {
		enable = true,
		timeout = 1,
		message = {
			new = "New bookmark '<key>' -> '<folder>'",
			delete = "Deleted bookmark in '<key>'",
			delete_all = "Deleted all bookmarks",
		},
	},
})

resolves #10

@Mcrtin
Copy link
Author

Mcrtin commented Jan 21, 2025

I just noticed, that the plugins I used as templates had two different ways of making the homemanger module

@Mcrtin
Copy link
Author

Mcrtin commented Jan 21, 2025

can someone help me with the init.lua?

@Mcrtin
Copy link
Author

Mcrtin commented Jan 22, 2025

I added the nested options; haven't tested it though

@haennes
Copy link
Contributor

haennes commented Jan 23, 2025

For Markdown I am not using any formatter. For the nix files running nix fmt should be fine.

@haennes
Copy link
Contributor

haennes commented Jan 24, 2025

Could you maybe use interactive rebase to revert the changes to the Markdown file, that were made by the formatter.
when you are inside the git rebase view you can use e to edit the commit.
then git reset HEAD~ once it drops you into the shell at that commit und now only stage the relevant lines and commit as normal

@Mcrtin
Copy link
Author

Mcrtin commented Jan 24, 2025

The problem is that they would be formatted differently from the rest of the rows; but if that's better sure

@lordkekz
Copy link
Owner

Don't worry too much about formatting or making a beautiful commit history. We can just squash it if it takes a few attempts xD

btw thanks for your PR, it looks good and I'll properly test & review it soon

@haennes
Copy link
Contributor

haennes commented Jan 26, 2025

looks great :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin wishlist: open-with-cmd, bookmarks, and hexyl
3 participants
@Mcrtin @haennes @lordkekz