Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clickable link monitors aren't underlined when editing status page #3795

Closed
2 tasks done
BBaoVanC opened this issue Sep 24, 2023 · 5 comments · Fixed by #3820
Closed
2 tasks done

Clickable link monitors aren't underlined when editing status page #3795

BBaoVanC opened this issue Sep 24, 2023 · 5 comments · Fixed by #3820
Labels
bug Something isn't working

Comments

@BBaoVanC
Copy link

BBaoVanC commented Sep 24, 2023

⚠️ Please verify that this bug has NOT been raised before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

After enabling clickable link on a monitor, it shows as underlined on the status page to hint that it is a link. However, in the edit status page menu, it doesn't show any as underlined. This combined with #3794 makes it hard to tell if a monitor is clickable before saving.

👟 Reproduction steps

  1. Have a monitor where clickable link is enabled (make sure you press Save on the entire page too)
    1. Go to "Edit Status Page"
    2. Press the settings cog next to the bbaovanc.com monitor
    3. Tick "Show Clickable Link"
      image
    4. Press Save in the bottom left of the entire page
  2. View that it is underlined on the actual status page
    image
  3. Click "Edit Status Page"
  4. View that it is not underlined
    image

👀 Expected behavior

Monitors with clickable link should be underlined in edit page

😓 Actual Behavior

They are not underlined in edit page

🐻 Uptime-Kuma Version

1.23.2

💻 Operating System and Arch

Debian 11

🌐 Browser

Firefox 117.0.1

🐋 Docker Version

Docker 24.0.6

🟩 NodeJS Version

No response

📝 Relevant log output

No response

@BBaoVanC BBaoVanC added the bug Something isn't working label Sep 24, 2023
@nayangoyal
Copy link

Hi, @BBaoVanC are you talking about this page? On this page, the underline is not present below the website name. Can you please help me by telling me that I am going in right way? I am new to open source and I want to solve this issue.

saved

@BBaoVanC
Copy link
Author

Hi, @BBaoVanC are you talking about this page? On this page, the underline is not present below the website name. Can you please help me by telling me that I am going in right way? I am new to open source and I want to solve this issue.

  1. Go to "Edit Status Page"
  2. Press the settings cog next to the bbaovanc.com monitor
  3. Tick "Show Clickable Link"
    image
  4. Press Save in the bottom left of the entire page

Now it should show the monitor as underlined, and you should be able to click it too. If you go back to "Edit Status Page", it's no longer underlined.

@nayangoyal
Copy link

I got that "Show Clickable Link" and I want to work on this issue can you assign this issue to me?

@BBaoVanC
Copy link
Author

I got that "Show Clickable Link" and I want to work on this issue can you assign this issue to me?

Only maintainers can assign an issue, but you can work on the issue yourself and make a pull request without being assigned to it.

@louislam
Copy link
Owner

I got that "Show Clickable Link" and I want to work on this issue can you assign this issue to me?

Bug fix is always welcome.

Don't forget to read https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants