Skip to content

Commit 5af7faf

Browse files
lpincalouwers
authored andcommitted
test: use valid hostnames
Use valid hostnames in `test/sequential/test-net-server-listen-ipv6-link-local.js`. Refs: nodejs#54554 PR-URL: nodejs#54556 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 19aff86 commit 5af7faf

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/sequential/test-net-server-listen-ipv6-link-local.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ if (!common.hasIPv6) {
1515
mock.method(dns, 'lookup', (hostname, options, callback) => {
1616
callback(new Error('Mocked error'));
1717
});
18-
const host = 'ipv6_link_local';
18+
const host = 'ipv6-link-local';
1919

2020
const server = net.createServer();
2121

@@ -30,13 +30,13 @@ if (!common.hasIPv6) {
3030
// Test on IPv6 Server, server.listen throws an error
3131
{
3232
mock.method(dns, 'lookup', (hostname, options, callback) => {
33-
if (hostname === 'ipv6_link_local') {
33+
if (hostname === 'ipv6-link-local') {
3434
callback(null, [{ address: 'fe80::1', family: 6 }]);
3535
} else {
3636
dns.lookup.wrappedMethod(hostname, options, callback);
3737
}
3838
});
39-
const host = 'ipv6_link_local';
39+
const host = 'ipv6-link-local';
4040

4141
const server = net.createServer();
4242

@@ -52,7 +52,7 @@ if (!common.hasIPv6) {
5252
{
5353

5454
mock.method(dns, 'lookup', (hostname, options, callback) => {
55-
if (hostname === 'ipv6_link_local_with_many_entries') {
55+
if (hostname === 'ipv6-link-local-with-many-entries') {
5656
callback(null, [
5757
{ address: 'fe80::1', family: 6 },
5858
{ address: 'fe80::abcd:1234', family: 6 },
@@ -84,7 +84,7 @@ if (!common.hasIPv6) {
8484
}
8585
});
8686

87-
const host = 'ipv6_link_local_with_many_entries';
87+
const host = 'ipv6-link-local-with-many-entries';
8888

8989
const server = net.createServer();
9090

@@ -103,11 +103,11 @@ if (!common.hasIPv6) {
103103
// Test on IPv6 Server, picks ::1 because the other address is a link-local address
104104
{
105105

106-
const host = 'ipv6_link_local_with_double_entry';
106+
const host = 'ipv6-link-local-with-double-entry';
107107
const validIpv6Address = '::1';
108108

109109
mock.method(dns, 'lookup', (hostname, options, callback) => {
110-
if (hostname === 'ipv6_link_local_with_double_entry') {
110+
if (hostname === 'ipv6-link-local-with-double-entry') {
111111
callback(null, [
112112
{ address: 'fe80::1', family: 6 },
113113
{ address: validIpv6Address, family: 6 },

0 commit comments

Comments
 (0)