add debug logging to the packet handler map #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-clemente
approved these changes
Jun 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #2608 +/- ##
==========================================
- Coverage 86.22% 86.21% -0.01%
==========================================
Files 122 122
Lines 9768 9777 +9
==========================================
+ Hits 8422 8429 +7
- Misses 1002 1004 +2
Partials 344 344
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm seeing a failing test case on the interop runner that might be caused by a session entry getting deleted too early. This PR adds some logging so I can see when connection IDs are added and removed from the map.