rewrite the proxy to avoid packet reordering #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
proxy-reordering
branch
3 times, most recently
from
a9fd4e7 to
5bb171d
Compare
marten-seemann
force-pushed
the
proxy-reordering
branch
from
5bb171d to
0baf16e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2617 +/- ##
=======================================
Coverage 86.21% 86.21%
=======================================
Files 122 122
Lines 9777 9777
=======================================
Hits 8429 8429
Misses 1004 1004
Partials 344 344 Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jun 22, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2616.
Packets that are getting delayed are added to a slice, which is then sorted by the timestamp when the packet should be sent. This is definitely not the most elegant solution in terms of scaling behavior, but I didn't want to use a linked list here either. This is a classic use case for an ordered map, but...