Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

handle Version Negotiation packets in the session #2640

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2639, fixes #2510.

@marten-seemann marten-seemann force-pushed the rewrite-version-negotiation-handling branch 2 times, most recently from bde0b44 to 4046f59 Compare June 30, 2020 15:25
@marten-seemann marten-seemann force-pushed the rewrite-version-negotiation-handling branch from 4046f59 to 06ad477 Compare July 1, 2020 07:19
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #2640 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2640      +/-   ##
==========================================
+ Coverage   86.31%   86.50%   +0.19%     
==========================================
  Files         121      121              
  Lines        9771    10045     +274     
==========================================
+ Hits         8433     8689     +256     
- Misses        996     1017      +21     
+ Partials      342      339       -3     
Impacted Files Coverage Δ
server.go 84.02% <ø> (+0.59%) ⬆️
client.go 73.24% <100.00%> (-5.05%) ⬇️
session.go 76.42% <100.00%> (+0.88%) ⬆️
internal/wire/transport_parameters.go 92.15% <0.00%> (+2.34%) ⬆️
internal/handshake/qtls.go 92.36% <0.00%> (+2.64%) ⬆️
internal/handshake/crypto_setup.go 71.64% <0.00%> (+5.11%) ⬆️
internal/handshake/unsafe.go 66.67% <0.00%> (+6.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b42c7a...06ad477. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants