enforce that a connection ID is not retired in a packet that uses that connection ID #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
enforce-conn-id-retirement-packet-conn-id
branch
from
48c6b97 to
1fa5a80
Compare
lucas-clemente
approved these changes
Jul 7, 2020
marten-seemann
commented
Jul 8, 2020
conn_id_generator.go
Outdated
| @@ -76,6 +76,9 @@ func (m *connIDGenerator) Retire(seq uint64) error { | |||
| if !ok { | |||
| return nil | |||
| } | |||
| if connID.Equal(sentWithDestConnID) { | |||
| return qerr.NewError(qerr.FrameEncodingError, fmt.Sprintf("tried to retire connection ID %d (%s), which was used as the Destination Connection ID on this packet", seq, connID)) | |||
There was a problem hiding this comment.
This should be a PROTOCOL_VIOLATION, see quicwg/base-drafts#3860.
marten-seemann
force-pushed
the
enforce-conn-id-retirement-packet-conn-id
branch
from
1fa5a80 to
25db216
Compare
Codecov Report
@@ Coverage Diff @@
## master #2651 +/- ##
=======================================
Coverage 86.44% 86.44%
=======================================
Files 122 122
Lines 9761 9763 +2
=======================================
+ Hits 8437 8439 +2
Misses 989 989
Partials 335 335
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The draft says: