Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add integration tests using faulty packet conns #2663

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2659. Depends on #2656.

This would have caught #2655. @ltucker, is it realistic to assume that if a connection fails, both ReadFrom and WriteTo will return an error?

@marten-seemann marten-seemann force-pushed the faulty-packet-conn-integration-test branch from 0ff71c4 to 1a0b642 Compare July 10, 2020 11:27
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #2663 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2663   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files         122      122           
  Lines        9749     9749           
=======================================
  Hits         8445     8445           
  Misses        971      971           
  Partials      333      333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbba00...1a0b642. Read the comment docs.

@marten-seemann marten-seemann merged commit 53856bd into master Jul 10, 2020
@marten-seemann marten-seemann deleted the faulty-packet-conn-integration-test branch July 10, 2020 12:16
@ltucker
Copy link
Contributor

ltucker commented Jul 11, 2020

@marten-seemann oh sorry missed this, I think this is usually the case relatively quickly in practice... I don't think golang technically claims anything about this property of the interface. I can imagine these error-ing at slightly different times due to differences in deadlines or something, but may not be worth the fidgety-ness / buy much.

@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test erroring connections
3 participants