Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

qlog draft-02 fixes #2987

Merged
merged 2 commits into from
Jan 15, 2021
Merged

qlog draft-02 fixes #2987

merged 2 commits into from
Jan 15, 2021

Conversation

marten-seemann
Copy link
Member

  • log the packet_size in the raw.length
  • always log the packet_type in the header

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #2987 (f28db16) into master (d1c5297) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2987      +/-   ##
==========================================
+ Coverage   86.12%   86.13%   +0.01%     
==========================================
  Files         135      135              
  Lines        9379     9387       +8     
==========================================
+ Hits         8077     8085       +8     
  Misses        943      943              
  Partials      359      359              
Impacted Files Coverage Δ
qlog/event.go 97.83% <100.00%> (+0.07%) ⬆️
qlog/packet_header.go 95.83% <100.00%> (+0.18%) ⬆️
qlog/qlog.go 94.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c5297...f28db16. Read the comment docs.

@marten-seemann marten-seemann merged commit 5eaf327 into master Jan 15, 2021
@marten-seemann marten-seemann deleted the qlog-draft-02-fixes branch January 15, 2021 09:10
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants