Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make the initial stream / connection flow control windows configurable #3083

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Mar 10, 2021

This is primarily to make 0-RTT better testable when we relax the resumption condition, see #3061.

As we're shifting more responsibility for setting these values to the application, we could say this fixes #88.

Should we rename the config options? The current ones are a bit of a mouthful. Suggestion:
Initial{Stream, Connection}FlowControlWindow => Initial{Stream, Connection}ReceiveWindow
MaxReceive{Stream, Connection}FlowControlWindow => Max{Stream, Connection}ReceiveWindow

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #3083 (a15cfd6) into master (9dcb56b) will increase coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
+ Coverage   86.03%   86.05%   +0.02%     
==========================================
  Files         132      132              
  Lines        9441     9449       +8     
==========================================
+ Hits         8122     8131       +9     
+ Misses        957      956       -1     
  Partials      362      362              
Impacted Files Coverage Δ
session.go 76.60% <90.00%> (ø)
config.go 100.00% <100.00%> (ø)
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcb56b...a15cfd6. Read the comment docs.

Copy link
Member

@lucas-clemente lucas-clemente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming sgtm.

@marten-seemann marten-seemann merged commit 59eb3ed into master Mar 16, 2021
@marten-seemann marten-seemann deleted the configure-initial-flow-control-window branch March 19, 2021 10:15
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

think about server parameter values
2 participants