Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make it possible to trace acknowledged packets #3134

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

marten-seemann
Copy link
Member

We need this to get an estimate of the packet loss rate: lost / (acked + lost).

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #3134 (c4073fb) into master (e098ccd) will decrease coverage by 0.03%.
The diff coverage is 54.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3134      +/-   ##
==========================================
- Coverage   85.47%   85.44%   -0.03%     
==========================================
  Files         131      131              
  Lines        9650     9653       +3     
==========================================
  Hits         8248     8248              
- Misses       1034     1036       +2     
- Partials      368      369       +1     
Impacted Files Coverage Δ
qlog/qlog.go 90.64% <0.00%> (-0.34%) ⬇️
internal/ackhandler/sent_packet_handler.go 77.25% <55.56%> (-0.44%) ⬇️
logging/multiplex.go 97.56% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e098ccd...c4073fb. Read the comment docs.

@marten-seemann marten-seemann merged commit ea14ce5 into master Apr 2, 2021
@marten-seemann marten-seemann deleted the trace-acked-packets branch April 2, 2021 10:37
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants