Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use HkdfExtract from x/crypto #3173

Merged
merged 1 commit into from
May 31, 2021
Merged

Conversation

marten-seemann
Copy link
Member

This means we don't have to expose it in qtls any more.

@marten-seemann marten-seemann force-pushed the use-x-crypto-hkdf-expand branch from 0c2c1ca to f712a59 Compare May 11, 2021 03:41
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #3173 (22112b7) into master (31191f7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3173      +/-   ##
==========================================
+ Coverage   85.43%   85.44%   +0.01%     
==========================================
  Files         133      133              
  Lines        9815     9813       -2     
==========================================
- Hits         8385     8384       -1     
+ Misses       1056     1055       -1     
  Partials      374      374              
Impacted Files Coverage Δ
internal/qtls/go115.go 58.33% <ø> (+4.49%) ⬆️
internal/qtls/go116.go 58.33% <ø> (+4.49%) ⬆️
internal/handshake/initial_aead.go 100.00% <100.00%> (ø)
internal/utils/rand.go 62.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31191f7...22112b7. Read the comment docs.

@marten-seemann marten-seemann force-pushed the use-x-crypto-hkdf-expand branch 3 times, most recently from b75db73 to 121cf2c Compare May 31, 2021 03:26
This means we don't have to expose it in qtls any more.
@marten-seemann marten-seemann force-pushed the use-x-crypto-hkdf-expand branch from 121cf2c to 22112b7 Compare May 31, 2021 03:27
@marten-seemann marten-seemann merged commit 99a936b into master May 31, 2021
@marten-seemann marten-seemann deleted the use-x-crypto-hkdf-expand branch May 31, 2021 04:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants