Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix DONT_FRAGMENT error when using a IPv6 connection on Windows #3178

Merged
merged 1 commit into from
May 11, 2021

Conversation

marten-seemann
Copy link
Member

The syscall setting the IP_DONTFRAGMENT socket option will fail if the underlying connection is a IPv6 connection. Since Go doesn't allow us to distinguish between IPv6 and dual-stack connections, we can only ignore the error here.

The syscall setting the IP_DONTFRAGMENT socket option will fail if the
underlying connection is a IPv6 connection. Since Go doesn't allow us to
distinguish between IPv6 and dual-stack connections, we can only ignore the
error here.
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #3178 (22a703b) into master (50746db) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
+ Coverage   85.35%   85.37%   +0.01%     
==========================================
  Files         133      133              
  Lines        9824     9819       -5     
==========================================
- Hits         8385     8382       -3     
+ Misses       1063     1062       -1     
+ Partials      376      375       -1     
Impacted Files Coverage Δ
conn_windows.go 56.52% <100.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50746db...22a703b. Read the comment docs.

@marten-seemann marten-seemann merged commit 0bc0e96 into master May 11, 2021
@marten-seemann marten-seemann deleted the fix-windows-ipv6-dontfragment branch May 11, 2021 20:02
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant