use the new zero-allocation control message parsing function from x/sys #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
parse-one-socket-control-message
branch
from
17853b8 to
ba1582e
Compare
8 tasks
Codecov ReportBase: 85.48% // Head: 85.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3609 +/- ##
=======================================
Coverage 85.48% 85.49%
=======================================
Files 140 140
Lines 10271 10273 +2
=======================================
+ Hits 8780 8782 +2
Misses 1106 1106
Partials 385 385
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Wonderful - reran my benchmarks against your commit - I'm seeing up to 12% decrease in allocations (both volume and bytes allocated) as well as up to 10% improvement in performance, especially for larger payloads. (Context: a QUIC-based proxy.) |
|
@kokes Thanks for the feedback! I'm really happy to hear that! |
lucas-clemente
approved these changes
Nov 3, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR was merged: https://go-review.googlesource.com/c/sys/+/425917 🍾
Closes #2889.