Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

expose the QUIC version of a connection #3620

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

MarcoPolo
Copy link
Collaborator

We already track the QUIC version in a connection. This simply exposes this in the public interface.

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's call this Version instead of QUICVersion.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 85.49% // Head: 85.48% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (559d22e) compared to base (7b211d6).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3620      +/-   ##
==========================================
- Coverage   85.49%   85.48%   -0.01%     
==========================================
  Files         142      142              
  Lines       10294    10295       +1     
==========================================
  Hits         8800     8800              
- Misses       1109     1110       +1     
  Partials      385      385              
Impacted Files Coverage Δ
connection.go 76.35% <0.00%> (-0.07%) ⬇️
interface.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

MarcoPolo and others added 2 commits November 14, 2022 17:50
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CI is unhappy (not gofmt-ed).

@MarcoPolo
Copy link
Collaborator Author

Should we make the version numbers non-internal? https://github.com/lucas-clemente/quic-go/blob/master/internal/protocol/version.go#L19

@marten-seemann
Copy link
Member

Should we make the version numbers non-internal? https://github.com/lucas-clemente/quic-go/blob/master/internal/protocol/version.go#L19

It already is, there's an alias in the quic package. We should probably use that one.

@MarcoPolo
Copy link
Collaborator Author

ah I can't believe I didn't see that at the top of the file.

Does this PR win for most back and forths relative to the code change?

@marten-seemann marten-seemann changed the title Expose the QUIC version of a connection expose the QUIC version of a connection Nov 15, 2022
@marten-seemann marten-seemann merged commit f2d3cb8 into quic-go:master Nov 15, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants