Fix autopipeling for buffer function + added built in commands #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamnoakes
commented
Nov 3, 2020
ShogunPanda
reviewed
Nov 4, 2020
ShogunPanda
reviewed
Nov 4, 2020
|
The PR LGTM to me, go on and file it! |
Ok great, i'll try get this PR ready in the next couple days |
adamnoakes
changed the title
|
This seems to have fallen through the cracks - @luin is anything holding up this PR from being merged? (It would also be useful for us). Thanks! 🙂 |
|
@luin anything new about it ? |
|
Hi @luin , any update on this? A friendly ping |
luin
approved these changes
May 22, 2021
ioredis-robot
pushed a commit
that referenced
this pull request
May 22, 2021
## [4.27.3](v4.27.2...v4.27.3) (2021-05-22) ### Bug Fixes * autopipeling for buffer function ([#1231](#1231)) ([abd9a82](abd9a82))
|
🎉 This PR is included in version 4.27.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Sorry for the delay! I overlooked the notifications for this thread. Awesome works @adamnoakes & @ShogunPanda! |
|
Hi @luin, thanks, I will try this change on Monday. Thanks @adamnoakes and @ShogunPanda |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.27.3](redis/ioredis@v4.27.2...v4.27.3) (2021-05-22) ### Bug Fixes * autopipeling for buffer function ([#1231](redis/ioredis#1231)) ([abd9a82](redis/ioredis@abd9a82))
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #1228
Also came across #621 whilst looking into this, and realised similar issue could exist for commands created via createBuiltinCommand, i added a suggested addBuiltinCommand to fix this.