(#778) perf: add checking and loading scripts uniqueness in pipeline #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaNightmare
changed the title
luin
reviewed
Jan 12, 2019
lib/pipeline.js
Outdated
| @@ -268,6 +268,8 @@ Pipeline.prototype.exec = function (callback) { | |||
|
|
|||
| return this.redis.script('exists', scripts.map(function (item) { | |||
| return item.sha; | |||
| }).filter(function (sha, index, shaList) { | |||
| return shaList.indexOf(sha) === index; | |||
| })).then(function (results) { | |||
There was a problem hiding this comment.
scripts.map(function (item) {
return item.sha;
}).filter(function (sha, index, shaList) {
return shaList.indexOf(sha) === index;
})Would be better to change to
Array.from(new Set(scripts.map(({sha}) => sha)))
luin
reviewed
Jan 12, 2019
test/functional/pipeline.js
Outdated
| @@ -12,7 +12,7 @@ describe('pipeline', function () { | |||
| [null, 3], | |||
| [null, '3'] | |||
| ]); | |||
| redis.disconnect() | |||
| redis.disconnect(); | |||
There was a problem hiding this comment.
Don't add ; here. Code style changes should belong to a separate pull request.
ioredis-robot
pushed a commit
that referenced
this pull request
Jan 13, 2019
## [4.5.1](v4.5.0...v4.5.1) (2019-01-13) ### Performance Improvements * add checking and loading scripts uniqueness in pipeline ([#781](#781)) ([66075ba](66075ba))
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.5.1](redis/ioredis@v4.5.0...v4.5.1) (2019-01-13) ### Performance Improvements * add checking and loading scripts uniqueness in pipeline ([#781](redis/ioredis#781)) ([66075ba](redis/ioredis@66075ba))
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#778