Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for TanStack Query v5 #73

Open
lithdew opened this issue Jul 3, 2023 · 5 comments
Open

Support for TanStack Query v5 #73

lithdew opened this issue Jul 3, 2023 · 5 comments
Assignees
Labels
will be resolved in a major release Feature or bug will be resolved in the next major release
Milestone

Comments

@lithdew
Copy link

lithdew commented Jul 3, 2023

Hi,

I wanted to put up a feature request for support for TanStack Query v5 which makes defaultPageParam mandatory in useInfiniteQuery and exposes pageParam and direction in QueryFnContext.

If there might be interest in supporting it, I would be happy to offer some help too.

@Daniel3711997
Copy link

any news here?

@gbyesiltas
Copy link

I have the same issue.

Additionally, I am having some issues with useQueries on v5. Queries that I define through query-key-factory that work fine with useQuery seem to have typing issues with useQueries. See screenshots:

Screenshot 2023-11-28 at 12 13 57 Screenshot 2023-11-28 at 12 14 08

@lukemorales
Copy link
Owner

Hey everyone, thank you for the suggestion in adding support for v5 new APIs, unfortunately I've been very busy lately without being able to put too much work into new features (the type system is extremely complex by now, so it takes some effort to add new things and not break things). I'll put this on my radar, but can't guarantee something in the near future.

Also, since there are some changes in APIs for V5, it would probably make sense to have a new major version with support only for v5 instead of adding here and being incompatible with a lot of folks that are still using V4.

@gbyesiltas from what I can see in your TS errors, the queries for useQueries expect some kind of MaybeRef that is making it incompatible with the normal function declaration. I'll need to understand the different signature it is expecting and see how we can make the type declaration compatible with its signature

@gbyesiltas
Copy link

Update from my side about useQueries, looks like this PR from tanstack-query did fix the typing issue :) 🥳

@lukemorales lukemorales added this to the v2 milestone Feb 9, 2024
@lukemorales lukemorales added the will be resolved in a major release Feature or bug will be resolved in the next major release label Feb 12, 2024
@lukemorales lukemorales self-assigned this Feb 12, 2024
@MartinHarkins
Copy link

Hey hey, we're interested in this ;)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
will be resolved in a major release Feature or bug will be resolved in the next major release
Projects
None yet
Development

No branches or pull requests

5 participants