feat: type gf on require file #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gf, and go to the 'c.lua' file
kylo252
reviewed
Oct 4, 2022
Comment on lines
+37
to
+38
| ext = ext or "lua" | ||
| local sep = dir_separator() |
There was a problem hiding this comment.
@SingularisArt, please fix the lint violations here, these two variables are not used
| end | ||
|
|
||
| -- Global function that searches the path for the required file | ||
| function find_required_path(module) |
There was a problem hiding this comment.
@SingularisArt, please avoid using global functions with generic names like this, consider move this function under lvim/utils or at very least add a prefix to the function.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now, when you're hovering over a require('a.b.c'), you can type gf, and go to the 'c.lua' file