Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sdl2_build_extra.py doesn't properly handle paths with spaces #70

Closed
insolace opened this issue Dec 16, 2024 · 3 comments
Closed

sdl2_build_extra.py doesn't properly handle paths with spaces #70

insolace opened this issue Dec 16, 2024 · 3 comments

Comments

@insolace
Copy link
Contributor

insolace commented Dec 16, 2024

The line "actions = exec_name," will fail if the path contains spaces. It should be changed to:

actions = '"{}"'.format(exec_name),

@fbiego
Copy link
Collaborator

fbiego commented Dec 20, 2024

does it also affect dependencies?

dependencies = exec_name,
actions = exec_name,

@insolace
Copy link
Contributor Author

It seems to only affect the execute action, not building. I'm on MacOS Sonoma for reference.

@fbiego
Copy link
Collaborator

fbiego commented Jan 6, 2025

#71

@fbiego fbiego closed this as completed Jan 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants