Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Discussion: the proper location of msg type files #42

Closed
takasehideki opened this issue Jun 13, 2023 · 1 comment · Fixed by #51
Closed

Discussion: the proper location of msg type files #42

takasehideki opened this issue Jun 13, 2023 · 1 comment · Fixed by #51

Comments

@takasehideki
Copy link
Member

takasehideki commented Jun 13, 2023

We initially thought the location of files related to the msg type of mros2 should be as follows.

However, there are some commonly used types, such as geometry_msgs and sensor_msgs. Actually, sensor_msgs is now located at this mros2 repository: https://github.com/mROS-base/mros2/tree/main/mros2_msgs/sensor_msgs/msg
So we need to discuss again which location is suitable to manage these types.

@takasehideki
Copy link
Member Author

I'm starting to think that the most commonly used types should be included in mros2_msgs/ (in this repository). This is because the generation of custom msg types is a common feature of mros2, not platform-dependent, and this way will make the usability higher.
The expected issue is that if users individually generate their own msg type files at their own locations, link conflict (duplication of include file) may happen.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant