Make oldFields mapping hardcoded to speed up system

tmotyl · tmotyl · commit 179c0b7eaa66 · 2020-06-23T10:25:30.000+02:00
The mapping came with Magneto 1.6 to provide a backward compatibility for old (pre 1.6) db field names. Now the mapping is hardcoded in the class instead of saved in the configuration. This improves performance as Magento will not create tons of objects for every new product/order/... entities. Related: OpenMage#920
diff --git a/app/code/core/Mage/Catalog/Model/Product.php b/app/code/core/Mage/Catalog/Model/Product.php
@@ -352,18 +352,6 @@ protected function _construct()
         $this->_init('catalog/product');
     }
 
-    /**
-     * Init mapping array of short fields to
-     * its full names
-     *
-     * @return Varien_Object
-     */
-    protected function _initOldFieldsMap()
-    {
-        $this->_oldFieldsMap = Mage::helper('catalog')->getOldFieldMap();
-        return $this;
-    }
-
     /**
      * Retrieve Store Id
      *
diff --git a/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php b/app/code/core/Mage/CatalogInventory/Model/Stock/Item.php
@@ -177,6 +177,7 @@ protected function _construct()
      */
     protected function _initOldFieldsMap()
     {
+        // pre 1.6 fields names, old => new
         $this->_oldFieldsMap = array(
             'stock_status_changed_automatically' => 'stock_status_changed_auto',
             'use_config_enable_qty_increments'   => 'use_config_enable_qty_inc'
diff --git a/app/code/core/Mage/Sales/Model/Order.php b/app/code/core/Mage/Sales/Model/Order.php
@@ -526,7 +526,12 @@ protected function _construct()
      */
     protected function _initOldFieldsMap()
     {
-        $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('order');
+        // pre 1.6 fields names, old => new
+        $this->_oldFieldsMap = [
+            'payment_authorization_expiration' => 'payment_auth_expiration',
+            'forced_do_shipment_with_invoice' => 'forced_shipment_with_invoice',
+            'base_shipping_hidden_tax_amount' => 'base_shipping_hidden_tax_amnt',
+        ];
         return $this;
     }
 
diff --git a/app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php b/app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php
@@ -153,7 +153,10 @@ public function setCreditmemo(Mage_Sales_Model_Order_Creditmemo $creditmemo)
      */
     protected function _initOldFieldsMap()
     {
-        $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('creditmemo_item');
+        // pre 1.6 fields names, old => new
+        $this->_oldFieldsMap = [
+            'base_weee_tax_applied_row_amount' => 'base_weee_tax_applied_row_amnt',
+        ];
         return $this;
     }
 
diff --git a/app/code/core/Mage/Sales/Model/Order/Invoice/Item.php b/app/code/core/Mage/Sales/Model/Order/Invoice/Item.php
@@ -125,7 +125,10 @@ public function _construct()
      */
     protected function _initOldFieldsMap()
     {
-        $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('invoice_item');
+        // pre 1.6 fields names, old => new
+        $this->_oldFieldsMap = [
+            'base_weee_tax_applied_row_amount' => 'base_weee_tax_applied_row_amnt',
+        ];
         return $this;
     }
     /**
diff --git a/app/code/core/Mage/Sales/Model/Order/Item.php b/app/code/core/Mage/Sales/Model/Order/Item.php
@@ -246,7 +246,10 @@ protected function _construct()
      */
     protected function _initOldFieldsMap()
     {
-        $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('order_item');
+        // pre 1.6 fields names, old => new
+        $this->_oldFieldsMap = [
+            'base_weee_tax_applied_row_amount' => 'base_weee_tax_applied_row_amnt',
+        ];
         return $this;
     }
 
diff --git a/app/code/core/Mage/Sales/etc/config.xml b/app/code/core/Mage/Sales/etc/config.xml
@@ -1198,13 +1198,6 @@
             </product>
         </catalog>
         <sales>
-            <old_fields_map>
-                <order>
-                    <payment_authorization_expiration>payment_auth_expiration</payment_authorization_expiration>
-                    <forced_do_shipment_with_invoice>forced_shipment_with_invoice</forced_do_shipment_with_invoice>
-                    <base_shipping_hidden_tax_amount>base_shipping_hidden_tax_amnt</base_shipping_hidden_tax_amount>
-                </order>
-            </old_fields_map>
             <quote>
                 <totals>
                     <nominal>
diff --git a/app/code/core/Mage/Weee/etc/config.xml b/app/code/core/Mage/Weee/etc/config.xml
@@ -225,17 +225,6 @@
                     </weee>
                 </totals>
             </order_creditmemo>
-            <old_fields_map>
-                <order_item>
-                    <base_weee_tax_applied_row_amount>base_weee_tax_applied_row_amnt</base_weee_tax_applied_row_amount>
-                </order_item>
-                <invoice_item>
-                    <base_weee_tax_applied_row_amount>base_weee_tax_applied_row_amnt</base_weee_tax_applied_row_amount>
-                </invoice_item>
-                <creditmemo_item>
-                    <base_weee_tax_applied_row_amount>base_weee_tax_applied_row_amnt</base_weee_tax_applied_row_amount>
-                </creditmemo_item>
-            </old_fields_map>
         </sales>
     </global>
     <adminhtml>

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,7 @@ protected function _construct()`
`177`	`177`	`*/`
`178`	`178`	`protected function _initOldFieldsMap()`
`179`	`179`	`{`
	`180`	`+ // pre 1.6 fields names, old => new`
`180`	`181`	`$this->_oldFieldsMap = array(`
`181`	`182`	`'stock_status_changed_automatically' => 'stock_status_changed_auto',`
`182`	`183`	`'use_config_enable_qty_increments' => 'use_config_enable_qty_inc'`
Original file line number	Diff line number	Diff line change
`@@ -526,7 +526,12 @@ protected function _construct()`
`526`	`526`	`*/`
`527`	`527`	`protected function _initOldFieldsMap()`
`528`	`528`	`{`
`529`		`- $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('order');`
	`529`	`+ // pre 1.6 fields names, old => new`
	`530`	`+ $this->_oldFieldsMap = [`
	`531`	`+ 'payment_authorization_expiration' => 'payment_auth_expiration',`
	`532`	`+ 'forced_do_shipment_with_invoice' => 'forced_shipment_with_invoice',`
	`533`	`+ 'base_shipping_hidden_tax_amount' => 'base_shipping_hidden_tax_amnt',`
	`534`	`+ ];`
`530`	`535`	`return $this;`
`531`	`536`	`}`
`532`	`537`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,10 @@ public function setCreditmemo(Mage_Sales_Model_Order_Creditmemo $creditmemo)`
`153`	`153`	`*/`
`154`	`154`	`protected function _initOldFieldsMap()`
`155`	`155`	`{`
`156`		`- $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('creditmemo_item');`
	`156`	`+ // pre 1.6 fields names, old => new`
	`157`	`+ $this->_oldFieldsMap = [`
	`158`	`+ 'base_weee_tax_applied_row_amount' => 'base_weee_tax_applied_row_amnt',`
	`159`	`+ ];`
`157`	`160`	`return $this;`
`158`	`161`	`}`
`159`	`162`
Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,10 @@ public function _construct()`
`125`	`125`	`*/`
`126`	`126`	`protected function _initOldFieldsMap()`
`127`	`127`	`{`
`128`		`- $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('invoice_item');`
	`128`	`+ // pre 1.6 fields names, old => new`
	`129`	`+ $this->_oldFieldsMap = [`
	`130`	`+ 'base_weee_tax_applied_row_amount' => 'base_weee_tax_applied_row_amnt',`
	`131`	`+ ];`
`129`	`132`	`return $this;`
`130`	`133`	`}`
`131`	`134`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,10 @@ protected function _construct()`
`246`	`246`	`*/`
`247`	`247`	`protected function _initOldFieldsMap()`
`248`	`248`	`{`
`249`		`- $this->_oldFieldsMap = Mage::helper('sales')->getOldFieldMap('order_item');`
	`249`	`+ // pre 1.6 fields names, old => new`
	`250`	`+ $this->_oldFieldsMap = [`
	`251`	`+ 'base_weee_tax_applied_row_amount' => 'base_weee_tax_applied_row_amnt',`
	`252`	`+ ];`
`250`	`253`	`return $this;`
`251`	`254`	`}`
`252`	`255`