Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

new esc.Run signature requires more template #61

Open
TomOnTime opened this issue Jul 1, 2019 · 1 comment
Open

new esc.Run signature requires more template #61

TomOnTime opened this issue Jul 1, 2019 · 1 comment

Comments

@TomOnTime
Copy link

I recently upgraded to the newest version of this module and I noticed that esc.Run() now requires an io.Writer. That's awesome, however old code requires a lot of template (see StackExchange/dnscontrol#515 for an example).

Would it make sense to have (for example) a nil writer result in the file being created automatically? This would help with migrating old code, and also would reduce the amount of template code needed.

Just a though!

@maddyblue
Copy link
Owner

Yes this should be the case.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants