Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DEPRECATION WARNING - !global assignments #303

Closed
khocef opened this issue Jul 10, 2020 · 4 comments
Closed

DEPRECATION WARNING - !global assignments #303

khocef opened this issue Jul 10, 2020 · 4 comments
Labels

Comments

@khocef
Copy link

khocef commented Jul 10, 2020

remote: [INFO] DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
remote: [INFO] declare new variables. Since this assignment is at the root of the stylesheet,
remote: [INFO] the !global flag is unnecessary and can safely be removed.
remote: [INFO]
remote: [INFO] ╷
remote: [INFO] 49 │ $wz-param-indicator-state: null !global;
remote: [INFO] │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
remote: [INFO] ╵
remote: [INFO] node_modules/angular-archwizard/variables.scss 49:1 @import
remote: [INFO] node_modules/angular-archwizard/archwizard.scss 1:9 @import
remote: [INFO] stdin 14:9 root stylesheet
remote: [INFO]
remote: [INFO] DEPRECATION WARNING: As of Dart Sass 2.0.0, !global assignments won't be able to
remote: [INFO] declare new variables. Since this assignment is at the root of the stylesheet,
remote: [INFO] the !global flag is unnecessary and can safely be removed.
remote: [INFO]
remote: [INFO] ╷
remote: [INFO] 52 │ $wz-param-indicator-color: null !global;
remote: [INFO] │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
remote: [INFO] ╵
remote: [INFO] node_modules/angular-archwizard/variables.scss 52:1 @import
remote: [INFO] node_modules/angular-archwizard/archwizard.scss 1:9 @import

@madoar
Copy link
Owner

madoar commented Jul 10, 2020

Which version of angular-archwizard are you using?

@khocef
Copy link
Author

khocef commented Jul 10, 2020

Version 5.0.1 with Angular 8.2.14

@madoar
Copy link
Owner

madoar commented Jul 12, 2020

This has been fixed in the version 6 releases. I thought I completely backported the fix to version 5.0.1 in #269 but it seems like I missed some changes.

I'm not sure whether I will backport the fix for the remaining variables, because of multiple reasons:

  • it is only a deprecation warning and does not break any code
  • it only affects the version 5 releases and not the current version 6 releases
  • Angular 10 has been released last month so I will release a version 7 of angular-archwizard soonish

Therefore I don't think that it is worth it to invest time into fixing these warning and publishing a new release.

@khocef
Copy link
Author

khocef commented Jul 13, 2020

okay, i will close the issue

@khocef khocef closed this as completed Jul 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants