Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

switch to GitHub Actions #83

Merged
merged 2 commits into from
Jun 14, 2022
Merged

switch to GitHub Actions #83

merged 2 commits into from
Jun 14, 2022

Conversation

msimerson
Copy link
Contributor

@msimerson msimerson commented May 31, 2022

  • chore(ci): switch reporter from nyc to c8
  • chore(nyc): remove dependency
  • move .eslintrc to .eslintrc.yaml (be explicit)
  • incorporates and closes Switch to GitHub Actions #76

Screen Shot 2022-05-31 at 3 34 17 PM

silverwind and others added 2 commits May 31, 2022 14:48
* chore(ci): switch to GitHub Actions
* chore(ci): switch reporter from nyc to c8
* chore(nyc): remove dependency
* move .eslintrc to .eslintrc.yaml (be explicit)
@msimerson
Copy link
Contributor Author

msimerson commented May 31, 2022

Notes

  • you can see a workflow run here.
  • you could move the eslint dependencies out of package.json and into the lint step
    • pro: faster CI steps
    • con: to get 'npm run lint' on the CLI, you'd need to use npx to install it
  • the needs: $step are optional, you can remove them instead of chaining
  • coverage is reported to both coveralls and codecov. Nuke one or the other, or not. 🤷‍♂️

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@dbfe59b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage          ?   98.00%           
=========================================
  Files             ?        6           
  Lines             ?     1854           
  Branches          ?        0           
=========================================
  Hits              ?     1817           
  Misses            ?       37           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfe59b...395815d. Read the comment docs.

@silverwind silverwind merged commit bd33c5f into mafintosh:master Jun 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants