-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add to fastify benchmarks #5
Comments
I don't think this is really relevant – this module is a level below a web framework – it's essentially a replacement for |
Good point! Maybe this quote from the readme could show the source code for the benchmark and test harness to produce the results. For example, is this one test run or an average of 50 test runs?
|
Not relevant. This is a HTTP server, as opposed to a server framework. Aka, this replaces |
Looks like someone went ahead and did it anyway: fastify/benchmarks#47 |
@lukeed so sth like this should qualify? https://github.com/emkay/theodore |
@tuananh The framework, yes. But only when it's running on |
Otherwise things like |
@lukeed I get your point. I just don't understand why using |
Because that's the most common module. Most people are using it, and all existing benchmark tests are already running with it. Turbo, UWS, etc are all upgrades. AKA, it's like showing up to a high school baseball game on a double dose of steroids -- it isn't fair. Best to benchmark on native / "raw" because it's already the baseline. Then let people upgrade to their preferred HTTP alternative if/when they want to. Also, when you make that upgrade, you're upgrading the server and not the framework. |
I understand now that it doesn't make sense to compare with fastify. @mafintosh How about adding it to https://www.techempower.com/benchmarks/ so that it can be compared to the node.js core http module and many other web frameworks? |
There are a bunch of http libs that claim to be fast.
And there is a benchmark to see who is fastest.
You should add
turbo-http
to the benchmarks repo and see how it measures up 😄https://github.com/fastify/benchmarks
The text was updated successfully, but these errors were encountered: