-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(upward): add UrlResolver and tests. Closes #1057 #1058
Conversation
This pull request is automatically deployed with Now. |
The docs look good to me. Unassigning myself so others can pick this up and review the implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor changes should make this a little easier to understand. If we've got sign off from the team that this is a priority, I can jump on the upward-php implementation, so start brushing up on your PHP so you can review that for me.
@zetlen - Ran a quick validation of this strategy, and we can move the What do you think of that approach? |
… zetlen/upward-add-url-resolver
@magento-research/core-pwa-devs Any other concerns before we merge? |
Description
Add an eighth Resolver to UPWARD, the UrlResolver.
upward-spec
, the cross-platform test suite.Related Issue
Closes #1057.
Related to #1045 and other issues resolving URLs for ServiceResolvers or ProxyResolvers..
Motivation and Context
See #1057; URLs should be a first class concept in UPWARD.
Verification
Experiment with URL resolution based on the documentation. Try different configurations in Venia.
How Has This Been Tested?
Full test coverage and integration test suite coverage.
Tried all cases in Venia where UPWARD resolves URLs. This resolver simplifies the Venia UPWARD definition and makes it more reliable.
Proposed Labels for Change Type/Package
FEATURE in upward-js
ENHANCEMENT in venia-concept
Checklist: