Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

False Positives When Using Path Repositories - Observers & Plugins #1597

Open
sprankhub opened this issue May 23, 2023 · 1 comment
Open
Labels
Advanced bug good first issue Priority: P3 May be fixed according to the position in the backlog

Comments

@sprankhub
Copy link
Member

Describe the bug (*)

When using a path repository for development, you'll often have two directories containing the same code. One in your path (and project), and one in the vendor directory. When this happens, the plugin will flag false positives.

To Reproduce (*)

Steps to reproduce the behavior:

  1. Include a Magento module with a Composer local path repository.
  2. Add a plugin to any class.
  3. Add an observer to any class.

Expected behavior (*)

No issues are reported for the plugin and for the observer.

Screenshots

Shamelessly taken from #372:

image

Please complete the following information: (*)

  • OS: Ubuntu Linux 22.04
  • PhpStorm/Intellij version: 2023.1.2
  • Plugin Version: 5.1.1

Additional context

The issue has already been reported in #372 and closed, but it is not solved yet / was introduced again.

@sprankhub sprankhub added the bug label May 23, 2023
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2023

Hi @sprankhub. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@VitaliyBoyko VitaliyBoyko added good first issue Advanced Priority: P3 May be fixed according to the position in the backlog labels Feb 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Advanced bug good first issue Priority: P3 May be fixed according to the position in the backlog
Projects
None yet
Development

No branches or pull requests

2 participants