Preconditions and environment

• Magento version: 2.4-develop

Steps to reproduce

1. Open the integration test dev/tests/integration/testsuite/Magento/Eav/Setup/EavSetupTest.php
2. Append a new test at the end of the file, which should definitely succeed. For example this one:

    public function testAddAttributeAfterInvalidAttributeCodesWereTriedToBeAdded(): void
    {
        $attributeData = $this->getAttributeData();
        $this->eavSetup->addAttribute(\Magento\Catalog\Model\Product::ENTITY, 'test_123', $attributeData);
    }

3. Now, execute all tests in the file (cd dev/tests/integration && ../../../vendor/bin/phpunit --filter EavSetupTest)

Expected result

All tests should be completed successfully.

Actual result

Our simple test fails, although it should not. The following message is outputted:

There was 1 error:

1. Magento\Eav\Setup\EavSetupTest::testAddAttributeAfterInvalidAttributeCodesWereTriedToBeAdded
   Magento\Framework\Exception\LocalizedException: An attribute code must not be less than 1 and more than 60 characters.\nAn attribute code must not be less than 1 and more than 60 characters.\nAn attribute code must not be less than 1 and more than 60 characters.\nAn attribute code must not be less than 1 and more than 60 characters.\nAttribute code "1first_character_is_not_letter" is invalid. Please use only letters (a-z or A-Z), numbers (0-9) or underscore () in this field, and the first character should be a letter.\nAttribute code "attribute.with.dots" is invalid. Please use only letters (a-z or A-Z), numbers (0-9) or underscore () in this field, and the first character should be a letter.

The reason is that during the previous tests, which tested to add attributes with invalid codes, the Magento\Eav\Model\Validator\Attribute\Code added error messages to its internal array, which are never resetted. That's why subsequent tests, which try to add attributes, will fail.

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.