Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug]: Unloaded states have inconsistent style #1272

Closed
6 tasks
zetlen opened this issue May 27, 2019 · 0 comments · Fixed by #1275
Closed
6 tasks

[bug]: Unloaded states have inconsistent style #1272

zetlen opened this issue May 27, 2019 · 0 comments · Fixed by #1275
Labels
bug Something isn't working

Comments

@zetlen
Copy link
Contributor

zetlen commented May 27, 2019

We have:

  • hand-coded HTML behind a <noscript> tag for no-JS browsers
  • simple placeholder text while the initial bundles load
  • a nice loading indicator
  • a static "not found" page

To Reproduce
Steps to reproduce the behavior:

  1. Open Chrome dev tools.
  2. Enter Mobile Emulation Mode.
  3. Drop down the "No throttling" menu and select "Fast 3G" (or equivalent).
  4. Visit venia.magento.com

Expected behavior
A smooth loading experience.

Screenshots

First Homepage Paint
First Homepage Paint

App data loading for all screens
App data loading for all screens

Page not found, loading
Page not found, loading

Page not found, loaded
Page not found, loaded

JS Disabled
JS Disabled

These states are wildly inconsistent with one another! They need to be brought in line.

Additional context
Related to #46, where we talk about our offline solutions in general.
We may have some future way of compiling certain React components down into static templates, or extracting critical CSS. However we fix this, it'll be a first pass.

Possible solutions
Add some minimal inlined CSS to visually match the in-app loading indicator. Replace the "Loading" text in the template with a styled version.

Rebuild the js-unavailable partial to reuse this style, to keep page size low.

Please complete the following device information:

  • iPhone SE in screenshots
  • PWA Studio Version: 2.1.0

Please let us know what packages this bug is in regards to:

  • venia-concept
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
@zetlen zetlen added the bug Something isn't working label May 27, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant