Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[feature]: Make Venia components less dependent on specific Webpack config #1502

Closed
1 of 6 tasks
zetlen opened this issue Jul 31, 2019 · 1 comment · Fixed by #1497 or #1498
Closed
1 of 6 tasks

[feature]: Make Venia components less dependent on specific Webpack config #1502

zetlen opened this issue Jul 31, 2019 · 1 comment · Fixed by #1497 or #1498
Assignees
@zetlen
Labels
enhancement New feature or request

Comments

@zetlen
Copy link
Contributor

zetlen commented Jul 31, 2019

Venia's root-relative imports and complex Webpack config file make it too easy to tightly couple its React components to the specific Venia app. If our code is to be portable this needs to change.

Describe the solution you'd like

  • An abstraction of Webpack config into Buildpack
  • Simplification and rigor applied to Venia

Additional context
Ultimately this will lead to modularity and a scaffolding story :)

Please let us know what packages this feature is in regards to:

  • venia-concept
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
@zetlen zetlen added the enhancement New feature or request label Jul 31, 2019
This was referenced Jul 31, 2019
Merged
Merged
@zetlen
Copy link
Contributor Author

zetlen commented Aug 7, 2019

Reopening because #1498 needs it as the tracking issue.

@zetlen zetlen reopened this Aug 7, 2019
This was referenced Jul 31, 2022
Open
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@zetlen zetlen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@zetlen